heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,920 Commits 1 Branch 0 Tags
Commit Graph

2920 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Christopher Allan Webber
d3604e2920 Unit tests for plugins defining their own config_spec.ini! 
This commit sponsored by David Ahmed.  Thank you!
 2013-05-08 11:02:53 -05:00
Christopher Allan Webber
7fadc33b80 Allow plugins to install their own config_spec.ini if they like. 
This commit sponsored by Timothy Vollmer.  Thanks Tim!
 2013-05-08 11:02:20 -05:00
Joar Wandborg
1422cab669 Removed unused imports in httpapiauth 2013-05-05 22:24:34 +02:00
Elrond
fc45b38626 Use collection.url_for_self more; Add missing /a. 
Using collection.url_for_self(request.urlgen) instead
of request.urlgen(lengthy) is so much nicer, so using
it around the place.

Also added a few missing </a> in one template.
 2013-05-05 14:29:57 +02:00
Elrond
d13cd99483 Fix typo in new stl MEDIA_MANAGER. 2013-05-02 23:38:07 +02:00
Elrond
7eec77ca90 Fix media manager reference in video. 
An uninstantiated bare media manager doesn't any more
support ["something"]. You need to do .something.
Fixed for .source_type().
 2013-04-30 23:44:56 +02:00
Praveen Kumar
761389507d Make all media types use the new MediaManager classes. 2013-04-30 22:09:25 +02:00
Elrond
b835e15319 Add warning about crypt/itsdangeroussecret.bin. 
You should not leak that file, really.
 2013-04-30 00:26:06 +02:00
Elrond
2e6ee596ad Create redir_obj and use it around. 
This is a shortcut function to redirect to the main page
for an object. Objects currently supported: media entries
and collections.

And go around and replace various places to use this.
 2013-04-28 23:09:20 +02:00
Elrond
8f88b1f6dc Rewrite resize_image to use proc_state.store_public. 
This hopefully makes the code nicer and easier to change.
 2013-04-27 17:25:39 +02:00
Elrond
3b359dddc7 image resizing: Refactor some decisions into resize_tool. 
Loading the thumb/medium sizes from the config, saving
things to the db, and loading the image is now all done by
resize_tool. It still calls resize_image for the actual
work.
 2013-04-27 17:19:50 +02:00
Elrond
f96c284e0a Make uuid look like a uuid. 
If we really have to create a visible uuid (for a slug in
this case), don't try to hide the fact that it is a uuid.
So format it like a uuid.
 2013-04-27 17:02:37 +02:00
Elrond
adf53036a5 Remove extra indentation left over from previous commit. 
This only removes an unneeded extra indentation, left over
from the previous removal of code around.

Extra commit so it is easy to check that it only changes
indentation.
 2013-04-27 15:08:42 +02:00
Elrond
2041ceae1f Fix translations for collections and drop useless try. 
Don't do:  _("With some value: %s" % value)
Please do: _("WIth some value: %s") % value

Fixed for collection messages.

Also removed a
  try:
    some_code.
  except Exception as e:
    raise

No point in doing that.

Fixing the indentation of some_code comes in an extra
commit, because changing indentation is annoying enough
alone, so don't mix it with other changes.
 2013-04-27 15:08:07 +02:00
Christopher Allan Webber
90e7fc6738 word-wrapping the public/queue storage explainations in storage.rst 2013-04-26 16:13:05 -05:00
Christopher Allan Webber
c4771d7247 Merge remote-tracking branch 'refs/remotes/npigeon/ticket-660' 2013-04-26 16:08:39 -05:00
Christopher Allan Webber
ea5fb2d9d4 Switch "sqlite_refcheck" keyword arg to "migrations" which Elrond thinks is cleaner 
Also, if migrations is true, *explicitly* say that foreign key checking is off
 2013-04-26 15:27:44 -05:00
Christopher Allan Webber
313b38f895 Don't turn on sqlite refcheck stuff during migrations 2013-04-26 15:09:03 -05:00
Christopher Allan Webber
d6251b29ec Merge remote-tracking branch 'refs/remotes/rodney757/issue643' into mergetest 2013-04-26 11:12:46 -05:00
Rodney Ewing
226f1771e2 Removed an unused import 2013-04-26 07:32:39 -07:00
Elrond
d891966424 Unit test for ReallyLazyProxy. 
LazyProxy caches its value. So create a unit test for
lazy_pass_to_ugettext to make sure its returned proxy
actually gives a different translation when the locale
is switched.
 2013-04-25 14:31:29 +02:00
Elrond
5ae0cbaa55 No lazy_* needed here; Add ReallyLazyProxy.__repr__. 
One should use lazy_* only if you have a good reason.

This one found by our unit tests!

For example add_message adds the message to the session,
the session needs to be serialized (with json) and well,
LazyProxy is not serializable.

To aid in debugging, gave our ReallyLazyProxy a __repr__.
 2013-04-25 14:31:29 +02:00
Christopher Allan Webber
c47be4b8ba Adding ReallyLazyProxy, a proxy that does what we expect :) 2013-04-24 16:40:30 -05:00
Christopher Allan Webber
a789b713f5 Switching non-forms back to using normal pass_to_ugettext 2013-04-24 16:40:30 -05:00
Aditi Mittal
665b9c420a Fix-bug-667-Use-lazy_pass_to_ugettext-for-forms. 2013-04-24 16:40:29 -05:00
Rodney Ewing
34d8bc9820 Check for duplicate collection slugs and make them unique. Add unique constraint to collection.slug model 2013-04-24 14:31:51 -07:00
Elrond
50cb512220 Create set_thread_locale and use it. 
Setting up a new template env should not directly touch the
translation tools, but go through a function in
translations.py.
 2013-04-24 22:30:50 +02:00
Elrond
c82a8ba54f resize_image: Change calling style a bit. 
- entry: not used, removed.
- proc_state: going to be used, added.
- size_limits: not used, removed.
 2013-04-24 15:20:32 +02:00
Alon Levy
cec9648c11 mediagoblin/submit/lib.py: fix typo 
Signed-off-by: Alon Levy <alon@pobox.com>
 2013-04-23 13:11:40 +02:00
Elrond
6bea8a9094 Create add_media_to_collection() 
The ideas is by Alon Levy.

Not only media_collect, but also other places might want to
add media to a collection. So refactor this into a function
for easier usage.
 2013-04-23 12:29:17 +02:00
Elrond
e6bd03d429 Doc string for ProcessingState. 2013-04-22 22:18:24 +02:00
Elrond
dc1ec36eb9 resize_image: Refactor config loading a small bit. 
Well, get the config into a local variable, for easier access.
 2013-04-21 19:26:57 +02:00
Elrond
fd1202b774 Cleanup storage after test, and test .delete_dir(). 
The storage tests work in the system's tmpdir. The python
docs say, we should clean up after using things.  Yes the
directory should be cleaned up on reboot, but if running
tests a lot, the tmpdir could fill up, so we should really
cleanup.

So use the new .delete_dir() on the storage interface to
cleanup test dirs and get them finally removed with
os.rmdir. All nicely packed into cleanup_storage().
 2013-04-21 19:26:57 +02:00
Christopher Allan Webber
449863863a Merge remote-tracking branch 'remotes/npigeon/ticket-601' 2013-04-20 17:19:56 -05:00
Christopher Allan Webber
8aa18b6682 bumping image quality to 90, after conversation with Elrond 2013-04-20 11:03:48 -05:00
Christopher Allan Webber
7bb26613a3 Bumping the default image quality up to 85. 2013-04-20 10:54:13 -05:00
dunkyp
35f6d6a750 image quality can be set in config file 
(cherry-picked from
 https://gitorious.org/~dunkyp/mediagoblin/dunkyps-mediagoblin/commits/image_quality)
 2013-04-20 10:54:13 -05:00
Elrond
12dccc4552 Refactor test configs. 
All the hook_* tests use the same config, so refactor it.
 2013-04-20 00:24:09 +02:00
Christopher Allan Webber
c5d8d30182 removing old callable utilities and porting stuff over. 2013-04-19 16:51:14 -05:00
Christopher Allan Webber
97e0a79f39 Let's not use reserved keywords :) 2013-04-19 16:31:23 -05:00
Christopher Allan Webber
51d5d3aa20 changing the things to document in api.rst 2013-04-19 16:29:03 -05:00
Christopher Allan Webber
a0e7699a45 Added new tests to test hook_transform() 2013-04-19 16:28:41 -05:00
Christopher Allan Webber
234ddad607 we should be returning the result, not None! 2013-04-19 16:28:24 -05:00
Christopher Allan Webber
d1146101bb Adjusting tests to use hook_handle and hook_runall 2013-04-19 16:16:26 -05:00
Christopher Allan Webber
eff722ef15 fixing hook_handle for when result is never assigned, avoid reference without assignent 2013-04-19 14:58:22 -05:00
Christopher Allan Webber
e49b7bf290 As Elrond points out, we might as well .pop() default_handler 2013-04-19 14:25:02 -05:00
Christopher Allan Webber
ff259f6bf3 Hooks: the Next Generation! 
I have not tested any of this but it looks right ;)
 2013-04-19 13:56:05 -05:00
Christopher Allan Webber
4d0191dcb8 A warning about the plugin API being unstable. 2013-04-19 13:22:03 -05:00
Christopher Allan Webber
dd7eac8223 And... pyblosxom code removed again :) 
We agreed on a new direction on IRC last night...
 2013-04-19 13:13:32 -05:00
Christopher Allan Webber
0ea7b48055 pyblosxom run_callback hoisted 2013-04-18 17:03:25 -05:00