4939 Commits

Author SHA1 Message Date
Andrew Browning
690597ef83 Fix #5432 - Comment report link doens't work
This builds on work done for #5376 and associates the correct comment
ID with comment report links.
2016-03-02 12:45:07 -05:00
Andrew Browning
289826dc46 Fix #5435 - Bad comment links cause server error
This patch addresses an issue where a server error is caused by
entering a non-existent comment ID in a media URL.
2016-03-02 12:31:55 -05:00
Jessica Tallon
161bc6b2c1 Fix #5376 - Ensure links have correct ID
This ensures that links to comments have the correct ID (the
ID of the Comment object) as well as fixing deletion on reports
and fixing a few other little things. I hope this fixes the #5376
issue, though cannot reproduce so unable to confirm.
2016-03-01 12:04:08 +00:00
Andrew Browning
1db8690fe9 Fix #5433 - Typo in decorators 2016-03-01 01:00:14 -05:00
Andrew Browning
d508435985 Fix #5431 - Typo in models
Fix a typo in models.py.
2016-03-01 00:28:42 -05:00
Jessica Tallon
7555d1084f Fixes #5421 - Ensures Report.object_id is nullable
It seems there was a commit for a while where the migration was
making Report.object_id NOT NULL and this caused an errror when
a report deleted the associated object (media). This migrtion
checks it's nullable and if not, alters it so it is.
2016-02-29 19:18:42 +00:00
Jessica Tallon
ab14059538 Migration for #5415 - I forgot it, Doh! 2016-02-29 19:04:44 +00:00
Jessica Tallon
4c3a621b6d Fix a typo in consolidate_reports migration 2016-02-29 18:17:42 +00:00
Jessica Tallon
2104c3e0f2 Fix #5415 - Deleted comments get removed properly when tombstones
The original wrapper existed and should be been removed, this fix
now ensures the TextComment removes the Comment wrapper to prevent
the deleted (comments which are tombstones) existing.
2016-02-29 15:40:34 +00:00
Jessica Tallon
7fa67404ee Simply for the Notification.object_id migration 2016-02-29 15:34:14 +00:00
Jessica Tallon
f20e508dbc Missing perens 2016-02-29 14:26:05 +00:00
Jessica Tallon
677bf0ef62 Fixed issue introduced in previous migration 2016-02-29 14:14:58 +00:00
Jessica Tallon
6efcab2d69 Change Notification.object_id to be ID of Comemnt not TextComment
This shouldn't really effect much but it is a needed change for the future
this changes the Notification.object_id to be the ID of the Comment (the link
table to the comment object) rather than TextComment (the comment object itself).

This is needed as now comments can be other things, other than TextComment.
2016-02-29 12:33:51 +00:00
Christopher Allan Webber
6d38b1858c No need for python-chardet in guix-env.scm
That was *already* upstream in guix!
2016-02-25 15:41:03 -08:00
Christopher Allan Webber
7e550fcb9d Email debug mode on Python 3 was printing bytestring representation for subject body
There's nothing useful about seeing b'foo\nbar\nbaz' printing to
stdout.  That's not what the user should get!
2016-02-25 15:38:28 -08:00
Christopher Allan Webber
3d78038a3c guix-env.scm: Remove python-paste and python-pastescript, add python-chardet
python-paste and python-pastescript are now part of Guix proper.
Working on getting python-chardet there as well.
2016-02-25 11:14:33 -08:00
Christopher Allan Webber
8b76211d74 Crediting iyzsong 2016-02-24 18:05:03 -08:00
Christopher Allan Webber
020ddf92ca Fix sturm (Ben Sturmfels)' attribution 2016-02-24 18:04:09 -08:00
Christopher Allan Webber
eb564614cb Fix ascii media type for Python 3. Fix by 宋文武 (iyzsong) 2016-02-24 17:54:34 -08:00
Christopher Allan Webber
410ab9cacd Oops, I forgot to include test_mgoblin_app_pdf.ini 2016-02-24 17:52:15 -08:00
Christopher Allan Webber
118ca330df Also switch "#!/usr/bin/env bash" to "#!/bin/sh" in compile-translations.sh 2016-02-24 13:45:03 -08:00
Christopher Allan Webber
d0a0947986 Add guix-env.scm to launch a Guix environment for hacking.
(Thanks to David Thompson for help on the MediaGoblin packaging, which
went into this a lot!)
2016-02-24 13:45:03 -08:00
Boris Bobrov
993e061873 Change viewitems to items
There is no viewitems in python3
2016-02-23 04:15:06 +03:00
Boris Bobrov
5eaf6c1120 do not show error message when it's not a exception
Gah, the previous patch was not enough! We cannot use text, we can only
use exception with a special attribute.

Lets return safe None for now an resolve this properly later, when we're
not in the freeze.
2016-02-23 04:03:27 +03:00
Boris Bobrov
7dcdc2dcc6 Catch import error when text is used as a reason instead of path
fail_error was used in import, but due to some changes text could appear
there and it caused an error.

There is little sense now to remove these text messages because they are
probably in databases already, so just ignore import errors.
2016-02-23 03:57:00 +03:00
Andrew Browning
1fe6f5d6d7 Fix issue #5411 sqlite connection closes
This update changes migrations to wrap db.execute results in a list to
keep the connection from closing for sqlite migrations.
2016-02-23 03:32:34 +03:00
Andrew Browning
5aa4ab0615 Fix issue 5422 Resend verification fails
If a user was logged in and already verified, the resend_verification
link would cause a server error. This fix addresses that by using the
correct syntax to query the username from the request.
2016-02-22 14:43:38 -08:00
Christopher Allan Webber
062e37899d Oh, we don't need Paste, but we do need PasteScript! 2016-02-20 13:25:45 -08:00
Christopher Allan Webber
e2212f944b Basic explaination of how to deploy with Python 3.
Could be better, but "works" for now.
2016-02-20 12:47:59 -08:00
Christopher Allan Webber
c9cdb03657 Move Ubuntu -> *buntu because of absurd trademark issues
For more context, see:
  http://joeyh.name/blog/entry/trademark_nonsense/
2016-02-19 11:51:20 -08:00
Christopher Allan Webber
5c58b69e51 Removing python 2.6 junk: argparse and a 2.6 classifier 2016-02-19 10:22:48 -08:00
Christopher Allan Webber
d61778a489 Switch from Paste for serving to Waitress
Incredibly, it looks like none of our documentation has to change taking
this route...!
2016-02-19 10:22:14 -08:00
Boris Bobrov
149f46f7d5 Cleanup setup.py
Remove old comments and duplicate requirements from setup.py
2016-02-18 09:42:24 +03:00
Christopher Allan Webber
4f798a8a0c Removed deprecated comment about wsgi environ being borked 2016-02-17 15:52:24 -08:00
Christopher Allan Webber
fa9c0576ba Fix another python 3 and unicode issue 2016-02-11 14:47:04 -08:00
Christopher Allan Webber
cd4a7492cd Fixing one more bytes vs string battle in Python 3 2016-02-11 11:36:05 -08:00
Christopher Allan Webber
64b989a756 #5416: Fix tests using the FileObjectAwareFile 2016-02-11 11:21:44 -08:00
Boris Bobrov
7c1287b66c Upgrade sqlalchemy and sa-migrate
Our versions were too old. And not compatible with python3.
2016-02-11 10:40:50 -08:00
Christopher Allan Webber
6199c8da8d Move "/usr/bin/env bash" to simply "/bin/sh"
This makes working with Guix easier.
2016-02-11 10:26:51 -08:00
Christopher Allan Webber
1eaad45f89 .iteritems() doesn't exist in Python 3, converted to .items() 2016-02-11 10:23:06 -08:00
Christopher Allan Webber
493698a536 Switch to #!/bin/sh (don't use "env" unless we have to)
env causes problems in GuixSD and maybe even some other places.
2016-02-10 11:11:02 -08:00
Christopher Allan Webber
850eabc325 Committing extracted and compiled translations 2016-02-07 09:28:51 -08:00
Loic Dachary
679f729221 Fix #5079 - tags unicity is on the slug, not the name
Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Andrew Browning <ayleph@thisshitistemp.com>
2016-02-06 14:33:49 -05:00
Boris Bobrov
05f26e3abc Do not calculate processing info for anonymous user 2016-02-05 05:38:18 +03:00
Boris Bobrov
fa858bd717 removed debug prints, added video icon 2016-02-05 05:30:34 +03:00
Boris Bobrov
654d7cf94f Display type icon in thumbnails 2016-02-05 05:30:28 +03:00
Boris Bobrov
3b6b009077 Merge branch 'media_panel' 2016-02-05 04:33:05 +03:00
Boris Bobrov
f13225fa6d Prevent dict changed during iteration in video 2016-02-05 04:32:19 +03:00
Boris Bobrov
157ee14b14 Merge branch 'master' of git.sv.gnu.org:/srv/git/mediagoblin 2016-02-05 04:32:07 +03:00
Christopher Allan Webber
5573c41054 Issue #5349: Submission tests fail confusingly on missing dependency
They gave a DetachedInstanceError, despite being totally unrelated to
anything in database-land!
2016-02-04 15:40:28 -08:00