heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Commit session after alembic updates have finished

Browse Source 
After alembic updates we need to add foundations. The tables to add
foundations to are created as part of dbupdate process. For some reason
Alembic doesn't commit a session in the end. Because the session is not
commited, the tables do not really get created. And because of that,
foundations fail.

The solution is to commit the session after alembic updates.
This commit is contained in:
Boris Bobrov 2017-04-01 21:07:01 +03:00
parent 3bad5310f6
commit a5dae0dbc2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mediagoblin/gmg_commands/dbupdate.py
View File

@ -133,7 +133,9 @@ def run_alembic_migrations(db, app_config, global_config):
session = Session()
cfg = build_alembic_config(global_config, None, session)
return command.upgrade(cfg, 'heads')
res = command.upgrade(cfg, 'heads')
session.commit()
return res
def run_dbupdate(app_config, global_config):
@ -146,7 +148,7 @@ def run_dbupdate(app_config, global_config):
# Set up the database
db = setup_connection_and_db_from_config(app_config, migrations=True)
# Do we have migrations
# Do we have migrations
should_run_sqam_migrations = db.engine.has_table("core__migrations") and \
sqam_migrations_to_run(db, app_config,
global_config)