heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some mostly cosmetic changes to CSRF

Browse Source 
* remove max_age - A session cookie is better, because it's
  a session thing, really.
* Call the cookie mediagoblin_csrftoken, much clearer.
* Use the SCRIPT_NAME for the path of the cookie, so that
  the cookie is sent back to the right place only.
  Alternatively the path= parameter could be removed, so
  that it defaults to '/'.
* call the randomness function only once, instead of twice.
  64 bits should be enough. If really more bits are needed,
  increase the number.
* Just give the number as cookie. No point in md5 and
  hexdigest in my view (those functions just make another
  representation).
* getrandbits gets a bit count directly, simpler API
This commit is contained in:
Elrond 2011-10-04 00:12:03 +02:00
parent 917d4663af
commit 2dc8d24932
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mediagoblin/config_spec.ini
View File

@ -42,7 +42,7 @@ celery_setup_elsewhere = boolean(default=False)
allow_attachments = boolean(default=False)
# Cookie stuff
csrf_cookie_name = string(default='mediagoblin_nonce')
csrf_cookie_name = string(default='mediagoblin_csrftoken')
[storage:publicstore]
storage_class = string(default="mediagoblin.storage.filestorage:BasicFileStorage")

15
mediagoblin/middleware/csrf.py
View File

@ -25,9 +25,9 @@ from mediagoblin import mg_globals
# Use the system (hardware-based) random number generator if it exists.
# -- this optimization is lifted from Django
if hasattr(random, 'SystemRandom'):
randrange = random.SystemRandom().randrange
getrandbits = random.SystemRandom().getrandbits
else:
randrange = random.randrange
getrandbits = random.getrandbits
class CsrfForm(Form):
@ -54,7 +54,7 @@ class CsrfMiddleware(object):
and matches the form token for non-safe requests.
"""
MAX_CSRF_KEY = 2 << 63
CSRF_KEYLEN = 64
SAFE_HTTP_METHODS = ("GET", "HEAD", "OPTIONS", "TRACE")
def __init__(self, mg_app):
@ -92,9 +92,8 @@ class CsrfMiddleware(object):
response.set_cookie(
mg_globals.app_config['csrf_cookie_name'],
request.environ['CSRF_TOKEN'],
max_age=60 * 60 * 24 * 7 * 52,
path='/',
domain=mg_globals.app_config.get('csrf_cookie_domain', None),
path=request.environ['SCRIPT_NAME'],
domain=mg_globals.app_config.get('csrf_cookie_domain'),
secure=(request.scheme.lower() == 'https'),
httponly=True)
@ -104,9 +103,7 @@ class CsrfMiddleware(object):
def _make_token(self, request):
"""Generate a new token to use for CSRF protection."""
return hashlib.md5("%s%s" %
(randrange(0, self.MAX_CSRF_KEY),
randrange(0, self.MAX_CSRF_KEY))).hexdigest()
return "%s" % (getrandbits(self.CSRF_KEYLEN),)
def verify_tokens(self, request):
"""Verify that the CSRF Cookie exists and that it matches the