plyr: use strict and fix undefined quality variable

This commit is contained in:
Jesús 2021-09-01 12:42:44 -05:00
parent 98d9b35765
commit 7143e1b321
No known key found for this signature in database
GPG Key ID: F6EE7BC59A315766

View File

@ -1,38 +1,40 @@
let captionsActive;
(function main() {
'use strict';
switch(true) {
case data.settings.subtitles_mode == 2:
let captionsActive;
switch(true) {
case data.settings.subtitles_mode == 2:
captionsActive = true;
break;
case data.settings.subtitles_mode == 1 && data.has_manual_captions:
case data.settings.subtitles_mode == 1 && data.has_manual_captions:
captionsActive = true;
break;
default:
default:
captionsActive = false;
}
}
var qualityOptions = [];
var qualityDefault;
for (var src of data['uni_sources']) {
let qualityOptions = [];
let qualityDefault;
for (var src of data['uni_sources']) {
qualityOptions.push(src.quality_string)
}
for (var src of data['pair_sources']) {
}
for (var src of data['pair_sources']) {
qualityOptions.push(src[0].quality_string)
}
if (data['using_pair_sources'])
}
if (data['using_pair_sources'])
qualityDefault = data['pair_sources'][data['pair_idx']][0].quality_string;
else if (data['uni_sources'].length != 0)
else if (data['uni_sources'].length != 0)
qualityDefault = data['uni_sources'][data['uni_idx']].quality_string;
else
else
qualityDefault = 'None';
// Fix plyr refusing to work with qualities that are strings
Object.defineProperty(Plyr.prototype, 'quality', {
// Fix plyr refusing to work with qualities that are strings
Object.defineProperty(Plyr.prototype, 'quality', {
set: function(input) {
const config = this.config.quality;
const options = this.options.quality;
let quality;
if (!options.length) {
return;
@ -67,9 +69,9 @@ Object.defineProperty(Plyr.prototype, 'quality', {
});
}
}
});
});
const player = new Plyr(document.getElementById('js-video-player'), {
const player = new Plyr(document.getElementById('js-video-player'), {
disableContextMenu: false,
captions: {
active: captionsActive,
@ -115,11 +117,12 @@ const player = new Plyr(document.getElementById('js-video-player'), {
},
},
settings: ['captions', 'quality', 'speed', 'loop'],
});
});
// Hide the external quality selector
window.addEventListener('DOMContentLoaded', function(){
var qs = document.getElementById('quality-select');
// Hide the external quality selector
window.addEventListener('DOMContentLoaded', function(){
const qs = document.getElementById('quality-select');
if (qs)
qs.hidden = true;
});
});
}());