* Removed trailing whitespace
* Line length < 80 where possible
* Honor conventions on number of blank lines
* Honor conventions about spaces around :, =
Handled in several places:
- In the run() of the ProcessMedia itself for
handled (BaseProcessingFail derived) errors (best to do these not
in on_failure because the errors are highlighted in celeryd in a
way that looks inappropriate for when the errors are well handled)
- In ProcessMedia.on_failure() for all other errors
- In the submit view where all exceptions are caught, media is marked
at having failed, then the error is re-raised. (The reason for
this is that users running in "lazy" mode will get errors
propagated by celery and so on_failure won't run for them.)
BaseProcessingFail based exceptions recorded and marked appropriately
in the database. Other exceptions also caught and marked (or rather
not marked) appropriately in the database as well.
- Currently there are individual calls to wtforms_util.render_field_div
for each field in the media submit form, which is too verbose
- Matched the field ordering in submit/form.py to the verbose version
- hacks the correct textareafield rendering with hard-coded rows and
columns.
- TODO - figure out how to pass the textarea dimensions with **kwargs
- adds a function to convert the tag list of dicts to a text string
properly delimited for loading into forms
- tag string conversion function updated to generate list of dicts
- updates all mentions of the conversion of the string to the tags db
object
- adds a tags template utility and updates the media template accordingly
- the function that converts the user's tag string into a list of
tags now accepts a string, but the media submit view was still
submitting the request object, like we were going to add any
errors to the session. Now the submit view passes the tag string
- seems simpler to use the same tag field processing procedures on media
submit and edit, so now processing with a regular function instead of
a form filter. Filters run on form load and post by default.
- moved tags to sidebar
- taglist defaults to [] instead of None
- adds case sensitivity toggle
page w/ a message
* Successful submission redirects to the logged in user's page
(your own, presumably).
* "Woohoo! Submitted!" is launched into the tube of session messages
to appear on next pageload. If you're not aborting in the window
of 210ms it takes for the client to respond to the 302 and load
the logged in user's/your page that is, YMMV.
