heckyel/mediagoblin
0
0
Fork 0
Code Issues Pull Requests Releases Activity

Removing the "enter your password to change your email" bit.

Browse Source 
A good idea, though it feels fairly clumsy in the form, and I think if
you're logged in you can already sabotage the user pretty well.

This commit sponsored by Sergey Matveev.  Thanks!
This commit is contained in:
Christopher Allan Webber
2013-06-21 17:24:33 -05:00
parent c482f0149d
commit f7698af1c1
4 changed files with 21 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
mediagoblin/tests/test_edit.py
View File

@@ -144,31 +144,6 @@ class TestUserEdit(object):
def test_email_change(self, test_app):
self.login(test_app)
# Test email change without password
template.clear_test_template_context()
test_app.post(
'/edit/account/', {
'new_email': 'new@example.com'})
# Check form errors
context = template.TEMPLATE_TEST_CONTEXT[
'mediagoblin/edit/edit_account.html']
assert context['form'].password.errors == [
u'This field is required.']
# Test email change with wrong password
template.clear_test_template_context()
test_app.post(
'/edit/account/', {
'new_email': 'new@example.com',
'password': 'wrong'})
# Check form errors
context = template.TEMPLATE_TEST_CONTEXT[
'mediagoblin/edit/edit_account.html']
assert context['form'].password.errors == [
u'Wrong password.']
# Test email already in db
template.clear_test_template_context()
test_app.post(
@@ -182,19 +157,6 @@ class TestUserEdit(object):
assert context['form'].new_email.errors == [
u'Sorry, a user with that email address already exists.']
# Test password is too short
template.clear_test_template_context()
test_app.post(
'/edit/account/', {
'new_email': 'new@example.com',
'password': 't'})
# Check form errors
context = template.TEMPLATE_TEST_CONTEXT[
'mediagoblin/edit/edit_account.html']
assert context['form'].password.errors == [
u'Field must be between 5 and 1024 characters long.']
# Test successful email change
template.clear_test_template_context()
res = test_app.post(