heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing check_filetype...

Browse Source 
We need to check the first part of the guess_type returned tuple, and
also this try: except: doesn't belong here, so killing.
This commit is contained in:
Christopher Allan Webber 2011-06-07 00:36:24 -05:00
parent fe4ffb860f
commit eb21f9a6cb
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mediagoblin/submit/security.py
View File

@ -16,19 +16,11 @@
from mimetypes import guess_type from mimetypes import guess_type
from Image import open as image_open
ALLOWED = ['image/jpeg', 'image/png', 'image/tiff', 'image/gif'] ALLOWED = ['image/jpeg', 'image/png', 'image/tiff', 'image/gif']
def check_filetype(posted_file): def check_filetype(posted_file):
if not guess_type(posted_file.filename) in ALLOWED: if not guess_type(posted_file.filename)[0] in ALLOWED:
return False
# TODO: This should be handled by the processing stage. We should
# handle error detection there.
try:
image = image_open(posted_file.file)
except IOError:
return False return False
return True return True