heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefer nose assert_* methods to the assert built-in.

Browse Source
This commit is contained in:
Brett Smith 2012-03-20 22:40:32 -04:00
parent c373903494
commit d1f52dc776
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
mediagoblin/tests/test_submission.py
View File

@ -82,12 +82,12 @@ class TestSubmission:
# Test blank form # Test blank form
# --------------- # ---------------
response, form = self.do_post({}, *FORM_CONTEXT) response, form = self.do_post({}, *FORM_CONTEXT)
assert form.file.errors == [u'You must provide a file.'] assert_equal(form.file.errors, [u'You must provide a file.'])
# Test blank file # Test blank file
# --------------- # ---------------
response, form = self.do_post({'title': 'test title'}, *FORM_CONTEXT) response, form = self.do_post({'title': 'test title'}, *FORM_CONTEXT)
assert form.file.errors == [u'You must provide a file.'] assert_equal(form.file.errors, [u'You must provide a file.'])
def check_url(self, response, path): def check_url(self, response, path):
assert_equal(urlparse.urlsplit(response.location)[2], path) assert_equal(urlparse.urlsplit(response.location)[2], path)
@ -137,9 +137,10 @@ class TestSubmission:
'tags': BAD_TAG_STRING}, 'tags': BAD_TAG_STRING},
*FORM_CONTEXT, *FORM_CONTEXT,
**self.upload_data(GOOD_JPG)) **self.upload_data(GOOD_JPG))
assert form.tags.errors == [ assert_equal(form.tags.errors, [
u'Tags must be shorter than 50 characters. Tags that are too long'\ u'Tags must be shorter than 50 characters. ' \
': ffffffffffffffffffffffffffuuuuuuuuuuuuuuuuuuuuuuuuuu'] 'Tags that are too long: ' \
'ffffffffffffffffffffffffffuuuuuuuuuuuuuuuuuuuuuuuuuu'])
def test_delete(self): def test_delete(self):
response, request = self.do_post({'title': 'Balanced Goblin'}, response, request = self.do_post({'title': 'Balanced Goblin'},
@ -168,8 +169,10 @@ class TestSubmission:
response, form = self.do_post({'title': 'Malicious Upload 1'}, response, form = self.do_post({'title': 'Malicious Upload 1'},
*FORM_CONTEXT, *FORM_CONTEXT,
**self.upload_data(EVIL_FILE)) **self.upload_data(EVIL_FILE))
assert re.match(r'^Could not extract any file extension from ".*?"$', str(form.file.errors[0])) assert_equal(len(form.file.errors), 1)
assert len(form.file.errors) == 1 assert_true(re.match(
r'^Could not extract any file extension from ".*?"$',
str(form.file.errors[0])))
def check_false_image(self, title, filename): def check_false_image(self, title, filename):
# NOTE: These images should ultimately fail, but they # NOTE: These images should ultimately fail, but they