Fix url_for_self mixup

Move changes from mongo/models:url_for_self back into
mixin:url_for_self.
This commit is contained in:
Elrond 2012-01-11 11:16:35 +01:00
parent 73079ac4b8
commit cb7ae1e433
2 changed files with 5 additions and 24 deletions

View File

@ -63,7 +63,7 @@ class MediaEntryMixin(object):
def main_mediafile(self): def main_mediafile(self):
pass pass
def url_for_self(self, urlgen): def url_for_self(self, urlgen, **extra_args):
""" """
Generate an appropriate url for ourselves Generate an appropriate url for ourselves
@ -75,12 +75,14 @@ class MediaEntryMixin(object):
return urlgen( return urlgen(
'mediagoblin.user_pages.media_home', 'mediagoblin.user_pages.media_home',
user=uploader.username, user=uploader.username,
media=self.slug) media=self.slug,
**extra_args)
else: else:
return urlgen( return urlgen(
'mediagoblin.user_pages.media_home', 'mediagoblin.user_pages.media_home',
user=uploader.username, user=uploader.username,
media=unicode(self._id)) media=unicode(self._id),
**extra_args)
def get_fail_exception(self): def get_fail_exception(self):
""" """

View File

@ -226,27 +226,6 @@ class MediaEntry(Document, MediaEntryMixin):
if duplicate: if duplicate:
self.slug = "%s-%s" % (self._id, self.slug) self.slug = "%s-%s" % (self._id, self.slug)
def url_for_self(self, urlgen, **extra_args):
"""
Generate an appropriate url for ourselves
Use a slug if we have one, else use our '_id'.
"""
uploader = self.get_uploader
if self.get('slug'):
return urlgen(
'mediagoblin.user_pages.media_home',
user=uploader.username,
media=self.slug,
**extra_args)
else:
return urlgen(
'mediagoblin.user_pages.media_home',
user=uploader.username,
media=unicode(self._id),
**extra_args)
def url_to_prev(self, urlgen): def url_to_prev(self, urlgen):
""" """
Provide a url to the previous entry from this user, if there is one Provide a url to the previous entry from this user, if there is one