From bc27a100fc05cea72c47d8ae446454d347d0a0ff Mon Sep 17 00:00:00 2001 From: Elrond Date: Sun, 1 Apr 2012 22:02:06 +0200 Subject: [PATCH] Fix unit tests for sql: cache media_id. Attributes of SQLAlchemy objects get "lost". So "cache" them locally in the code. This is really the simple explanation for some scarry sqlalchemy details. --- mediagoblin/tests/test_submission.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mediagoblin/tests/test_submission.py b/mediagoblin/tests/test_submission.py index 788dfacf..9b503f4f 100644 --- a/mediagoblin/tests/test_submission.py +++ b/mediagoblin/tests/test_submission.py @@ -183,8 +183,9 @@ class TestSubmission: assert_true(media) # Add a comment, so we can test for its deletion later. + media_id = media.id get_comments = lambda: list( - request.db.MediaComment.find({'media_entry': media._id})) + request.db.MediaComment.find({'media_entry': media_id})) assert_false(get_comments()) response = self.test_app.post( request.urlgen('mediagoblin.user_pages.media_post_comment', @@ -200,7 +201,7 @@ class TestSubmission: request.urlgen('mediagoblin.user_pages.media_confirm_delete', # No work: user=media.uploader().username, user=self.test_user.username, - media=media._id), + media=media_id), # no value means no confirm {})