Don't disable existing loggers when initialising Celery.

Prior to this change, the Celery logging did not include any of the logging
calls within MediaGoblin because `disable_existing_loggers` defaulted to True.
This was unhelpful and inconsistent with the logging behaviour of the web process.

The MediaGoblin web process sets logging output based on the configuration in
paste.ini. This is loaded by the `paster` program, rather than MediaGoblin
itself.

The MediaGoblin celery process manually loads its logging config from paste.ini,
but previously defaulted to `disable_existing_loggers=True`, meaning that none
of the application logging flowed through unless the logger was explicitly added
to paste.ini.
This commit is contained in:
Ben Sturmfels 2021-08-23 13:26:25 +10:00
parent cfe50e6400
commit b3d3d33c96
No known key found for this signature in database
GPG Key ID: 023C05E2C9C068F0
2 changed files with 2 additions and 1 deletions

View File

@ -50,6 +50,7 @@ This chapter has important information about our current and previous releases.
- Fix test suite on Debian 11 (Ben Sturmfels)
- Remove reference to jsonschema.compat no longer available upstream (Marco Pessotto)
- Fix images being marked as failed after Celery restart [#5608] (Ben Sturmfels)
- Fix app logging calls not showing in Celery logs (Ben Sturmfels)
0.11.0

View File

@ -45,7 +45,7 @@ def setup_logging_from_paste_ini(loglevel, **kw):
raise OSError('{} does not exist. Logging can not be set up.'.format(
logging_conf_file))
logging.config.fileConfig(logging_conf_file)
logging.config.fileConfig(logging_conf_file, disable_existing_loggers=False)
hook_runall('celery_logging_setup')