Pass validated username to check_login_simple
The login function in mediagoblin/auth/views.py grabs the username prior to form validation. If validation passes, the pre-validated username is passed to the check_login_simple function. Lowercasifying of the username occurs as part of form validation. By sending the pre-validated username, there's a chance of sending a username with uppercase letters. This will fail to match any user ids in the database, as all of the usernames are lowercased during the registration process. This change sends the post-validated username to check_login_simple, so that any username that was entered by the user with uppercase letters has a chance to be properly lowercased before being passed.
This commit is contained in:
parent
aa50cab0dc
commit
a2b3c623fd
@ -86,10 +86,11 @@ def login(request):
|
||||
login_failed = False
|
||||
|
||||
if request.method == 'POST':
|
||||
username = login_form.username.data
|
||||
|
||||
if login_form.validate():
|
||||
user = check_login_simple(username, login_form.password.data)
|
||||
user = check_login_simple(
|
||||
login_form.username.data,
|
||||
login_form.password.data)
|
||||
|
||||
if user:
|
||||
# set up login in session
|
||||
|
Loading…
x
Reference in New Issue
Block a user