Move the call to install_migration_version_if_missing() to migrations_to_run()

This means there's a serious side effect of calling this, but there's
no way to get useful data here unless if that's set anyway.
This commit is contained in:
Christopher Allan Webber 2011-07-10 18:43:08 -05:00
parent 1b38cfa3b7
commit 9cf8b469e7

View File

@ -231,7 +231,14 @@ class MigrationManager(object):
def migrations_to_run(self):
"""
Get a list of migrations to run still, if any.
Note that calling this will set your migration version to the
latest version if it isn't installed to anything yet!
"""
# If we aren't set to any version number, presume we're at the
# latest (which means we'll do nothing here...)
self.install_migration_version_if_missing()
db_current_migration = self.database_current_migration()
return [
@ -251,11 +258,6 @@ class MigrationManager(object):
run post-migration. Takes (migration_number, migration_func)
as arguments
"""
# If we aren't set to any version number, presume we're at the
# latest (which means we'll do nothing here...)
# @@: should this be in migrations_to_run()?
self.install_migration_version_if_missing()
for migration_number, migration_func in self.migrations_to_run():
if pre_callback:
pre_callback(migration_number, migration_func)