I have a strong preference for aligning all parameters in a function call.

This commit is contained in:
Christopher Allan Webber 2011-06-05 15:41:08 -05:00
parent a7fcc027aa
commit 9038c9f9ac
5 changed files with 24 additions and 15 deletions

View File

@ -56,13 +56,15 @@ def register(request):
return redirect(request, "mediagoblin.auth.register_success") return redirect(request, "mediagoblin.auth.register_success")
return render_to_response(request, return render_to_response(
request,
'mediagoblin/auth/register.html', 'mediagoblin/auth/register.html',
{'register_form': register_form}) {'register_form': register_form})
def register_success(request): def register_success(request):
return render_to_response(request, return render_to_response(
request,
'mediagoblin/auth/register_success.html', {}) 'mediagoblin/auth/register_success.html', {})
@ -96,7 +98,8 @@ def login(request):
auth_lib.fake_login_attempt() auth_lib.fake_login_attempt()
login_failed = True login_failed = True
return render_to_response(request, return render_to_response(
request,
'mediagoblin/auth/login.html', 'mediagoblin/auth/login.html',
{'login_form': login_form, {'login_form': login_form,
'next': request.GET.get('next') or request.POST.get('next'), 'next': request.GET.get('next') or request.POST.get('next'),
@ -132,7 +135,8 @@ def verify_email(request):
else: else:
verification_successful = False verification_successful = False
return render_to_response(request, return render_to_response(
request,
'mediagoblin/auth/verify_email.html', 'mediagoblin/auth/verify_email.html',
{'user': user, {'user': user,
'verification_successful': verification_successful}) 'verification_successful': verification_successful})
@ -144,8 +148,8 @@ def verify_email_notice(request):
When the user tries to do some action that requires their account When the user tries to do some action that requires their account
to be verified beforehand, this view is called upon! to be verified beforehand, this view is called upon!
""" """
return render_to_response(request, return render_to_response(
'mediagoblin/auth/verification_needed.html', {}) request, 'mediagoblin/auth/verification_needed.html', {})
def resend_activation(request): def resend_activation(request):
@ -164,5 +168,5 @@ def resend_activation(request):
def resend_activation_success(request): def resend_activation_success(request):
return render_to_response(request, return render_to_response(
'mediagoblin/auth/resent_verification_email.html', {}) request, 'mediagoblin/auth/resent_verification_email.html', {})

View File

@ -54,7 +54,8 @@ def edit_media(request, media):
return redirect(request, "mediagoblin.user_pages.media_home", return redirect(request, "mediagoblin.user_pages.media_home",
user=media.uploader()['username'], media=media['slug']) user=media.uploader()['username'], media=media['slug'])
return render_to_response(request, return render_to_response(
request,
'mediagoblin/edit/edit.html', 'mediagoblin/edit/edit.html',
{'media': media, {'media': media,
'form': form}) 'form': form})

View File

@ -77,11 +77,12 @@ def submit_start(request):
return redirect(request, "mediagoblin.submit.success") return redirect(request, "mediagoblin.submit.success")
return render_to_response(request, return render_to_response(
request,
'mediagoblin/submit/start.html', 'mediagoblin/submit/start.html',
{'submit_form': submit_form}) {'submit_form': submit_form})
def submit_success(request): def submit_success(request):
return render_to_response(request, return render_to_response(
'mediagoblin/submit/success.html', {}) request, 'mediagoblin/submit/success.html', {})

View File

@ -42,7 +42,8 @@ def user_home(request, page):
if media_entries == None: if media_entries == None:
return exc.HTTPNotFound() return exc.HTTPNotFound()
return render_to_response(request, return render_to_response(
request,
'mediagoblin/user_pages/user.html', 'mediagoblin/user_pages/user.html',
{'user': user, {'user': user,
'media_entries': media_entries, 'media_entries': media_entries,
@ -52,7 +53,8 @@ def user_home(request, page):
@get_user_media_entry @get_user_media_entry
def media_home(request, media): def media_home(request, media):
"""'Homepage' of a MediaEntry()""" """'Homepage' of a MediaEntry()"""
return render_to_response(request, return render_to_response(
request,
'mediagoblin/user_pages/media.html', 'mediagoblin/user_pages/media.html',
{'media': media}) {'media': media})

View File

@ -21,6 +21,7 @@ def root_view(request):
media_entries = request.db.MediaEntry.find( media_entries = request.db.MediaEntry.find(
{u'state': u'processed'}).sort('created', DESCENDING) {u'state': u'processed'}).sort('created', DESCENDING)
return render_to_response(request, return render_to_response(
request,
'mediagoblin/root.html', 'mediagoblin/root.html',
{'media_entries': media_entries}) {'media_entries': media_entries})