heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve runtime of one test.

Browse Source 
Do not commit so often. flushing is enough.
This commit is contained in:
Elrond 2013-01-29 21:45:16 +01:00
parent ff68ca9fc2
commit 3f931680e3
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mediagoblin/tests/test_misc.py
View File

@ -16,6 +16,7 @@
from nose.tools import assert_equal from nose.tools import assert_equal
from mediagoblin.db.base import Session
from mediagoblin.db.models import User, MediaEntry, MediaComment from mediagoblin.db.models import User, MediaEntry, MediaComment
from mediagoblin.tests.tools import get_app, \ from mediagoblin.tests.tools import get_app, \
fixture_add_user, fixture_media_entry fixture_add_user, fixture_media_entry
@ -31,8 +32,11 @@ def test_user_deletes_other_comments():
user_a = fixture_add_user(u"chris_a") user_a = fixture_add_user(u"chris_a")
user_b = fixture_add_user(u"chris_b") user_b = fixture_add_user(u"chris_b")
media_a = fixture_media_entry(uploader=user_a.id) media_a = fixture_media_entry(uploader=user_a.id, save=False)
media_b = fixture_media_entry(uploader=user_b.id) media_b = fixture_media_entry(uploader=user_b.id, save=False)
Session.add(media_a)
Session.add(media_b)
Session.flush()
# Create all 4 possible comments: # Create all 4 possible comments:
for u_id in (user_a.id, user_b.id): for u_id in (user_a.id, user_b.id):
@ -41,13 +45,15 @@ def test_user_deletes_other_comments():
cmt.media_entry = m_id cmt.media_entry = m_id
cmt.author = u_id cmt.author = u_id
cmt.content = u"Some Comment" cmt.content = u"Some Comment"
cmt.save() Session.add(cmt)
Session.flush()
usr_cnt1 = User.query.count() usr_cnt1 = User.query.count()
med_cnt1 = MediaEntry.query.count() med_cnt1 = MediaEntry.query.count()
cmt_cnt1 = MediaComment.query.count() cmt_cnt1 = MediaComment.query.count()
User.query.get(user_a.id).delete() User.query.get(user_a.id).delete(commit=False)
usr_cnt2 = User.query.count() usr_cnt2 = User.query.count()
med_cnt2 = MediaEntry.query.count() med_cnt2 = MediaEntry.query.count()