heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* Bug #671: Tags list on Edit page is not seperated by spaces and hard to read : Make 'media_tags_as_string' function put a space after each comma.

Browse Source 
* Feature #678: Drop custom delimiters in tags : I declare a constant in the begining of text.py file.
This commit is contained in:
Manuel Urbano Santos 2011-11-27 13:49:47 +01:00
parent 3018832153
commit 3038ba87e4
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mediagoblin/config_spec.ini
View File

@ -27,7 +27,6 @@ email_smtp_pass = string(default=None)
allow_registration = boolean(default=True) allow_registration = boolean(default=True)
# tag parsing # tag parsing
tags_delimiter = string(default=",")
tags_max_length = integer(default=50) tags_max_length = integer(default=50)
# Whether comments are ascending or descending # Whether comments are ascending or descending

5
mediagoblin/tools/text.py
View File

@ -43,6 +43,7 @@ HTML_CLEANER = Cleaner(
host_whitelist=(), host_whitelist=(),
whitelist_tags=set([])) whitelist_tags=set([]))
TAGS_DELIMITER=',';
def clean_html(html): def clean_html(html):
# clean_html barfs on an empty string # clean_html barfs on an empty string
@ -67,7 +68,7 @@ def convert_to_tag_list_of_dicts(tag_string):
# Split the tag string into a list of tags # Split the tag string into a list of tags
for tag in stripped_tag_string.split( for tag in stripped_tag_string.split(
mg_globals.app_config['tags_delimiter']): TAGS_DELIMITER):
# Ignore empty or duplicate tags # Ignore empty or duplicate tags
if tag.strip() and tag.strip() not in [t['name'] for t in taglist]: if tag.strip() and tag.strip() not in [t['name'] for t in taglist]:
@ -85,7 +86,7 @@ def media_tags_as_string(media_entry_tags):
""" """
media_tag_string = '' media_tag_string = ''
if media_entry_tags: if media_entry_tags:
media_tag_string = mg_globals.app_config['tags_delimiter'].join( media_tag_string = (TAGS_DELIMITER+u' ').join(
[tag['name'] for tag in media_entry_tags]) [tag['name'] for tag in media_entry_tags])
return media_tag_string return media_tag_string