More efficient first element fetching and Dot-Notation.

_get_tag_name_from_entries:
1) Replace:
     if q.count():
       elem = q[0]
   by:
     for element in q:
       ...
       break

   this doesn't do two db queries but only one.

2) And another dose of Dot-Notation as usual.
This commit is contained in:
Elrond 2012-03-16 17:57:27 +01:00
parent 1b4d9edaef
commit 1eff10fa0f

View File

@ -29,11 +29,13 @@ def _get_tag_name_from_entries(media_entries, tag_slug):
"""
# ... this is slightly hacky looking :\
tag_name = tag_slug
if media_entries.count():
for tag in media_entries[0]['tags']:
# if media_entries.count():
for entry in media_entries:
for tag in entry.tags:
if tag['slug'] == tag_slug:
tag_name = tag['name']
break
break
return tag_name