Remove html5slider Javascript helper

This helper was originally added as a "polyfill"
(backward-compatibility shim) for Firefox version 23 and older, so
that <input type="range"> that audio.js uses could render nicely in
those versions of Firefox.

Chromium did not need this shim, and Firefox 23 (released on Aug 6,
2013) added support for this. Therefore, let us remove this
dependency. By current metrics at caniuse.com
<http://caniuse.com/#feat=input-range>, 88.14% of web users support
this attribute. Opera Mini and old versions of Internet Explorer (6-8)
are the only holdouts.

Note also that the html5slider.js is uninterested in adding this to
the npm package manager (or any package manager) repository
<https://github.com/fryn/html5slider/issues/5>, meaning that keeping
it in the mediagoblin extlib section would mean manual
maintenance/updating by the GNU MediaGoblin team.

This commit also removes GMG's use of the shim.
This commit is contained in:
Asheesh Laroia
2015-02-07 17:36:22 -08:00
committed by Christopher Allan Webber
parent d7404e7a4f
commit 1a7d401c32
4 changed files with 3 additions and 276 deletions

View File

@@ -1,5 +1,3 @@
<link rel="stylesheet" type="text/css" href="{{ request.staticdirect('/css/audio.css') }}" />
<script type="text/javascript" src="{{ request.staticdirect(
'/js/extlib/html5slider.js') }}"></script>
<script type="text/javascript" src="{{ request.staticdirect(
'/js/audio.js') }}"></script>

View File

@@ -1 +0,0 @@
../../../../extlib/html5slider/html5slider.js

View File

@@ -21,8 +21,6 @@
{% block mediagoblin_head %}
{{ super() }}
<link rel="stylesheet" type="text/css" href="{{ request.staticdirect('/css/audio.css') }}" />
<script type="text/javascript" src="{{ request.staticdirect(
'/js/extlib/html5slider.js') }}"></script>
<script type="text/javascript" src="{{ request.staticdirect(
'/js/audio.js') }}"></script>
{% endblock %}
@@ -42,10 +40,10 @@
<source src="{{ request.app.public_store.file_url(
media.media_files.webm_audio) }}" type="audio/webm; codecs=vorbis" />
<div class="no_html5">
{%- trans -%}Sorry, this audio will not work because
your web browser does not support HTML5
{%- trans -%}Sorry, this audio will not work because
your web browser does not support HTML5
audio.{%- endtrans -%}<br/>
{%- trans -%}You can get a modern web browser that
{%- trans -%}You can get a modern web browser that
can play the audio at <a href="http://getfirefox.com">
http://getfirefox.com</a>!{%- endtrans -%}
</div>