From 193e0f534621f0f50f1fa05a3fc63e73ff0513e8 Mon Sep 17 00:00:00 2001 From: Elrond Date: Sat, 10 Mar 2012 22:34:06 +0100 Subject: [PATCH] Improve logging of sql queries a bit. Docs: http://docs.sqlalchemy.org/en/latest/core/engines.html#configuring-logging So for an application utilizing python logging for real (and MediaGoblin should) the rule is: - Don't use echo=True, - but reconfigure the appropiate loggers' level. So replaced the echo=True by a line to reconfigure the appropiate logger to achieve the same effect. This still dumps whole bloats of SQL queries into the main log, but at least they're not duped any more. --- mediagoblin/db/sql/open.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mediagoblin/db/sql/open.py b/mediagoblin/db/sql/open.py index a8677bcb..b1f389e8 100644 --- a/mediagoblin/db/sql/open.py +++ b/mediagoblin/db/sql/open.py @@ -16,6 +16,7 @@ from sqlalchemy import create_engine +import logging from mediagoblin.db.sql.base import Session from mediagoblin.db.sql.models import Base @@ -41,7 +42,8 @@ class DatabaseMaster(object): def setup_connection_and_db_from_config(app_config): - engine = create_engine(app_config['sql_engine'], echo=True) + engine = create_engine(app_config['sql_engine']) + logging.getLogger('sqlalchemy.engine').setLevel(logging.INFO) Session.configure(bind=engine) return "dummy conn", DatabaseMaster(engine)