Remove Mongoism query.skip()

sqlalchemy supports slice() or [n:m] just fine.

Right now, it seems we cannot distinguish beween "empty" results
and out-of bound slices. It would be nice if we could distinguish
these somehow.

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>

mediagoblin/db/sql/base.py

@@ -35,9 +35,6 @@ class GMGQuery(Query):
             key_col = desc(key_col)
         return self.order_by(key_col)
 
-    def skip(self, amount):
-        return self.offset(amount)
-
 
 Session = scoped_session(sessionmaker(query_cls=GMGQuery))
 

mediagoblin/tools/pagination.py

@@ -63,8 +63,11 @@ class Pagination(object):
         """
         Returns slice of objects for the requested page
         """
-        return self.cursor.skip(
-            (self.page - 1) * self.per_page).limit(self.per_page)
+        # TODO, return None for out of index so templates can
+        # distinguish between empty galleries and out-of-bound pages???
+        return self.cursor.slice(
+            (self.page - 1) * self.per_page,
+            self.page * self.per_page)
 
     @property
     def pages(self):