heckyel/mediagoblin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests/auth: Don't rely on case sensitive error strings

Browse Source 
webob's 404 status is "404 NOT FOUND" while werkzeug's is
"404 Not Found". Our test suite was checking the upper case string
for equality. Just test the status error code "404" rather than the
full string which might change at some points/versions and should
not need to be tested.

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
This commit is contained in:
Sebastian Spaeth 2012-12-12 11:54:43 +01:00
parent 950124e640
commit 0eff207dff
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mediagoblin/tests/test_auth.py
View File

@ -266,7 +266,7 @@ def test_register_views(test_app):
response = test_app.get( response = test_app.get(
"/auth/forgot_password/verify/?userid=%s&token=total_bs" % unicode( "/auth/forgot_password/verify/?userid=%s&token=total_bs" % unicode(
new_user.id), status=404) new_user.id), status=404)
assert_equal(response.status, '404 Not Found') assert_equal(response.status.split()[0], u'404') # status="404 NOT FOUND"
## Try using an expired token to change password, shouldn't work ## Try using an expired token to change password, shouldn't work
template.clear_test_template_context() template.clear_test_template_context()
@ -275,7 +275,7 @@ def test_register_views(test_app):
new_user.fp_token_expire = datetime.datetime.now() new_user.fp_token_expire = datetime.datetime.now()
new_user.save() new_user.save()
response = test_app.get("%s?%s" % (path, get_params), status=404) response = test_app.get("%s?%s" % (path, get_params), status=404)
assert_equal(response.status, '404 Not Found') assert_equal(response.status.split()[0], u'404') # status="404 NOT FOUND"
new_user.fp_token_expire = real_token_expiration new_user.fp_token_expire = real_token_expiration
new_user.save() new_user.save()